ALSA: sound: Move dereference after NULL test and drop unnecessary NULL tests
authorJulia Lawall <julia@diku.dk>
Sat, 17 Oct 2009 06:33:22 +0000 (08:33 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 30 Oct 2009 11:01:27 +0000 (12:01 +0100)
In pcm.c, if the NULL test on pcm is needed, then the dereference should be
after the NULL test.

In dummy.c and ali5451.c, the context of the calls to
snd_card_dummy_new_mixer and snd_ali_free_voice show that dummy and pvoice,
respectively cannot be NULL.

A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

No differences found