common: avb_verify: Fix never-occurring avb_free(ops_data)
authorEugeniu Rosca <roscaeugeniu@gmail.com>
Tue, 14 Aug 2018 00:43:08 +0000 (02:43 +0200)
committerTom Rini <trini@konsulko.com>
Fri, 24 Aug 2018 17:19:53 +0000 (13:19 -0400)
Cppcheck (v1.85) reports w/o this patch:

[common/avb_verify.c:738] -> [common/avb_verify.c:741]: (warning) \
  Either the condition 'ops' is redundant or there is possible null \
  pointer dereference: ops.

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>
common/avb_verify.c

index 0bc1c23..0234f98 100644 (file)
@@ -766,7 +766,7 @@ void avb_ops_free(AvbOps *ops)
 {
        struct AvbOpsData *ops_data;
 
-       if (ops)
+       if (!ops)
                return;
 
        ops_data = ops->user_data;