ARM: OMAP2+: GPMC: resolve type-conversion warning from sparse
authorPaul Walmsley <paul@pwsan.com>
Fri, 13 Apr 2012 12:34:28 +0000 (06:34 -0600)
committerPaul Walmsley <paul@pwsan.com>
Fri, 13 Apr 2012 12:34:28 +0000 (06:34 -0600)
arch/arm/mach-omap2/gpmc.c passes a return value from ioremap() as the
fifth argument to request_irq() without casting it.  This causes
sparse to generate the following warning:

arch/arm/mach-omap2/gpmc.c:759:63: warning: incorrect type in argument 5 (different address spaces)
arch/arm/mach-omap2/gpmc.c:759:63:    expected void *dev
arch/arm/mach-omap2/gpmc.c:759:63:    got void [noderef] <asn:2>*static [toplevel] [assigned] gpmc_base

It turns out that it's not necessary to pass this.  gpmc_base is a
file-scoped static variable, the ISR is located in the same file ... and
the ISR doesn't even touch the passed-in variable.  So, just replace it with
NULL in request_irq().

Signed-off-by: Paul Walmsley <paul@pwsan.com>
arch/arm/mach-omap2/gpmc.c

index 00d5108..580e684 100644 (file)
@@ -755,8 +755,7 @@ static int __init gpmc_init(void)
                irq++;
        }
 
-       ret = request_irq(gpmc_irq,
-                       gpmc_handle_irq, IRQF_SHARED, "gpmc", gpmc_base);
+       ret = request_irq(gpmc_irq, gpmc_handle_irq, IRQF_SHARED, "gpmc", NULL);
        if (ret)
                pr_err("gpmc: irq-%d could not claim: err %d\n",
                                                gpmc_irq, ret);