net: cortina_ni: Fix typo accessing wrong phy
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Fri, 1 Aug 2025 11:59:40 +0000 (12:59 +0100)
committerJerome Forissier <jerome.forissier@linaro.org>
Mon, 18 Aug 2025 13:47:58 +0000 (15:47 +0200)
In ca_phy_probe when checking for an external phy it uses a field from
the internal phy due to what is assumed to be a copy/paste typo. Make
the obvious fix to use the field from the external phy.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
drivers/net/cortina_ni.c

index 7902688..21b7089 100644 (file)
@@ -499,7 +499,7 @@ static int ca_phy_probe(struct udevice *dev)
                                 dev, priv->phy_interface);
        if (ext_phydev) {
                ext_phydev->supported &= PHY_GBIT_FEATURES;
-               ext_phydev->advertising = int_phydev->supported;
+               ext_phydev->advertising = ext_phydev->supported;
                phy_config(ext_phydev);
        } else {
                printf("CA NI %s: There is no external phy device\n", __func__);