USB: adutux: NULL dereferences on disconnect
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 26 Nov 2014 14:06:49 +0000 (17:06 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 20 Feb 2015 00:49:28 +0000 (00:49 +0000)
commit fc625960edecfb57e62c2975d1f155155e28e6ba upstream.

Both "dev->udev" and "interface->dev" are NULL.  These printks are not
very interesting so I just deleted them.

Fixes: 03270634e242 ('USB: Add ADU support for Ontrak ADU devices')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/misc/adutux.c

index db5128b..501ab4f 100644 (file)
@@ -865,15 +865,11 @@ static void adu_disconnect(struct usb_interface *interface)
        usb_set_intfdata(interface, NULL);
 
        /* if the device is not opened, then we clean up right now */
-       dbg(2," %s : open count %d", __func__, dev->open_count);
        if (!dev->open_count)
                adu_delete(dev);
 
        mutex_unlock(&adutux_mutex);
 
-       dev_info(&interface->dev, "ADU device adutux%d now disconnected\n",
-                (minor - ADU_MINOR_BASE));
-
        dbg(2," %s : leave", __func__);
 }