git.openpandora.org / pandora-kernel.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 910e88a)
parisc: isa-eeprom - Fix loff_t usage
authorMichael Buesch <mb@bu3sch.de>
Mon, 20 Jul 2009 22:58:44 +0000 (22:58 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 1 Apr 2010 22:52:25 +0000 (15:52 -0700)
commit 6b4dbcd86a9d464057fcc7abe4d0574093071fcc upstream.

loff_t is a signed type. If userspace passes a negative ppos, the "count"
range check is weakened. "count"s bigger than HPEE_MAX_LENGTH will pass the check.
Also, if ppos is negative, the readb(eisa_eeprom_addr + *ppos) will poke in random
memory.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/parisc/eisa_eeprom.c patch | blob | history

diff --cc drivers/parisc/eisa_eeprom.c
Simple merge
Pandora Kernel Repository