mach-snapdragon: of_fixup: fix property length at writing
authorRui Miguel Silva <rui.silva@linaro.org>
Thu, 27 Feb 2025 09:45:49 +0000 (09:45 +0000)
committerCaleb Connolly <caleb.connolly@linaro.org>
Thu, 10 Apr 2025 13:43:09 +0000 (15:43 +0200)
The length of a property includes '\0' in a string type one, so
the length passed by needs to have that in account, if not,
when getting the property value it will fail because it
has the wrong size.

Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Tested-by: caleb.connolly@linaro.org # db845c
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250227094911.497219-2-rui.silva@linaro.org
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
arch/arm/mach-snapdragon/of_fixup.c

index 55368dd..ea956a4 100644 (file)
@@ -86,13 +86,13 @@ static int fixup_qcom_dwc3(struct device_node *glue_np)
        }
 
        /* Overwrite "phy-names" to only contain a single entry */
-       ret = of_write_prop(dwc3, "phy-names", strlen("usb2-phy"), "usb2-phy");
+       ret = of_write_prop(dwc3, "phy-names", strlen("usb2-phy") + 1, "usb2-phy");
        if (ret) {
                log_err("Failed to overwrite 'phy-names' property: %d\n", ret);
                return ret;
        }
 
-       ret = of_write_prop(dwc3, "maximum-speed", strlen("high-speed"), "high-speed");
+       ret = of_write_prop(dwc3, "maximum-speed", strlen("high-speed") + 1, "high-speed");
        if (ret) {
                log_err("Failed to set 'maximum-speed' property: %d\n", ret);
                return ret;