git.openpandora.org
/
pandora-kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2dcb407
)
libata-core: auditting chk_status v check_status
author
Alan Cox
<alan@lxorguk.ukuu.org.uk>
Tue, 23 Oct 2007 15:50:02 +0000
(16:50 +0100)
committer
Jeff Garzik
<jeff@garzik.org>
Wed, 24 Oct 2007 01:20:02 +0000
(21:20 -0400)
Did a complete audit of these and found we have another error case.
ata_bus_softreset calls ata_check_status which means that it tries to do
an ioread8 on the port blindly and check versus 0xFF for an error.
It should of course be using the ap->ops method for this via chk_status,
and this bug causes a wrog status call on the NS87415 at least.
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-core.c
patch
|
blob
|
history
diff --cc
drivers/ata/libata-core.c
Simple merge