nfsd4: fix acl buffer overrun
authorJ. Bruce Fields <bfields@redhat.com>
Tue, 11 Feb 2014 16:29:05 +0000 (11:29 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 11 Feb 2014 18:48:11 +0000 (13:48 -0500)
4ac7249ea5a0ceef9f8269f63f33cc873c3fac61 "nfsd: use get_acl and
->set_acl" forgets to set the size in the case get_acl() succeeds, so
_posix_to_nfsv4_one() can then write past the end of its allocation.
Symptoms were slab corruption warnings.

Also, some minor cleanup while we're here.  (Among other things, note
that the first few lines guarantee that pacl is non-NULL.)

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4acl.c

Simple merge