ima: Do not free 'entry' before it is initialized
authorChristoph Paasch <christoph.paasch@uclouvain.be>
Sun, 1 Dec 2013 23:05:20 +0000 (00:05 +0100)
committerMimi Zohar <zohar@linux.vnet.ibm.com>
Tue, 3 Dec 2013 01:46:32 +0000 (20:46 -0500)
7bc5f447ce9d0 (ima: define new function ima_alloc_init_template() to
API) moved the initialization of 'entry' in ima_add_boot_aggregate() a
bit more below, after the if (ima_used_chip).

So, 'entry' is not initialized while being inside this if-block. So, we
should not attempt to free it.

Found by Coverity (CID: 1131971)

Fixes: 7bc5f447ce9d0 (ima: define new function ima_alloc_init_template() to API)
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
security/integrity/ima/ima_init.c

index 15f34bd..76b8e2c 100644 (file)
@@ -63,7 +63,6 @@ static void __init ima_add_boot_aggregate(void)
                result = ima_calc_boot_aggregate(&hash.hdr);
                if (result < 0) {
                        audit_cause = "hashing_error";
-                       kfree(entry);
                        goto err_out;
                }
        }