net: ravb: Allocate bb_miiphy using bb_miiphy_alloc() and fill in callbacks
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Sat, 22 Feb 2025 20:33:25 +0000 (21:33 +0100)
committerMarek Vasut <marek.vasut+renesas@mailbox.org>
Wed, 26 Feb 2025 17:26:57 +0000 (18:26 +0100)
Allocate bb_miiphy using bb_miiphy_alloc() and fill in callbacks
currently listed in bb_miiphy_buses[] array. This is a temporary
duplication of assignment to avoid breakage, which will be removed
in follow up patches. At this point, the bb_miiphy callbacks can
reach these accessors by doing container_of() on struct mii_dev.

Reviewed-by: Paul Barker <paul.barker.ct@bp.renesas.com>
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
drivers/net/ravb.c

index 381cf25..0018b69 100644 (file)
@@ -553,6 +553,7 @@ static int ravb_probe(struct udevice *dev)
 {
        struct eth_pdata *pdata = dev_get_plat(dev);
        struct ravb_priv *eth = dev_get_priv(dev);
+       struct bb_miiphy_bus *bb_miiphy;
        struct mii_dev *mdiodev;
        void __iomem *iobase;
        int ret;
@@ -564,17 +565,29 @@ static int ravb_probe(struct udevice *dev)
        if (ret < 0)
                goto err_mdio_alloc;
 
-       mdiodev = mdio_alloc();
-       if (!mdiodev) {
+       bb_miiphy = bb_miiphy_alloc();
+       if (!bb_miiphy) {
                ret = -ENOMEM;
                goto err_mdio_alloc;
        }
 
+       mdiodev = &bb_miiphy->mii;
+
        mdiodev->read = bb_miiphy_read;
        mdiodev->write = bb_miiphy_write;
        bb_miiphy_buses[0].priv = eth;
        snprintf(mdiodev->name, sizeof(mdiodev->name), dev->name);
 
+       /* Copy the bus accessors, name and private data */
+       bb_miiphy->mdio_active = ravb_bb_mdio_active;
+       bb_miiphy->mdio_tristate = ravb_bb_mdio_tristate;
+       bb_miiphy->set_mdio = ravb_bb_set_mdio;
+       bb_miiphy->get_mdio = ravb_bb_get_mdio;
+       bb_miiphy->set_mdc = ravb_bb_set_mdc;
+       bb_miiphy->delay = ravb_bb_delay;
+       strlcpy(bb_miiphy->name, "ravb", MDIO_NAME_LEN);
+       bb_miiphy->priv = eth;
+
        ret = mdio_register(mdiodev);
        if (ret < 0)
                goto err_mdio_register;
@@ -599,7 +612,7 @@ static int ravb_probe(struct udevice *dev)
 err_mdio_reset:
        clk_release_bulk(&eth->clks);
 err_mdio_register:
-       mdio_free(mdiodev);
+       bb_miiphy_free(bb_miiphy);
 err_mdio_alloc:
        unmap_physmem(eth->iobase, MAP_NOCACHE);
        return ret;