spl: Make SHOW_ERRORS depend on LIBCOMMON
authorSean Anderson <seanga2@gmail.com>
Wed, 8 Nov 2023 16:48:35 +0000 (11:48 -0500)
committerTom Rini <trini@konsulko.com>
Thu, 16 Nov 2023 18:49:13 +0000 (13:49 -0500)
The purpose of SHOW_ERRORS is to print extra information. Make it depend
on LIBCOMMON to avoid having to check for two configs.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
common/spl/Kconfig
common/spl/spl.c

index 00332cf..e929f1b 100644 (file)
@@ -183,6 +183,7 @@ config SPL_SYS_REPORT_STACK_F_USAGE
 
 config SPL_SHOW_ERRORS
        bool "Show more information when something goes wrong"
+       depends on SPL_LIBCOMMON_SUPPORT
        help
          This enabled more verbose error messages and checking when something
          goes wrong in SPL. For example, it shows the error code when U-Boot
index 732d90d..7ce38ce 100644 (file)
@@ -718,8 +718,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
        ret = boot_from_devices(&spl_image, spl_boot_list,
                                ARRAY_SIZE(spl_boot_list));
        if (ret) {
-               if (CONFIG_IS_ENABLED(SHOW_ERRORS) &&
-                   CONFIG_IS_ENABLED(LIBCOMMON_SUPPORT))
+               if (CONFIG_IS_ENABLED(SHOW_ERRORS))
                        printf(SPL_TPL_PROMPT "failed to boot from all boot devices (err=%d)\n",
                               ret);
                else