ALSA: HDA: Fix Oops caused by dereference NULL pointer
authorWang YanQing <udknight@gmail.com>
Tue, 7 May 2013 03:27:33 +0000 (11:27 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 30 May 2013 13:34:52 +0000 (14:34 +0100)
commitfcc6acda6626851e42aa3c74d9b8d3dfe49d87d1
tree84e8084d64afd58a223c4df80e7ddc9db86a7e75
parent9670f6d8280fa5be96c38e7f8415c70eafd511c7
ALSA: HDA: Fix Oops caused by dereference NULL pointer

commit 2195b063f6609e4c6268f291683902f25eaf9aa6 upstream.

The interrupt handler azx_interrupt will call azx_update_rirb,
which may call snd_hda_queue_unsol_event, snd_hda_queue_unsol_event
will dereference chip->bus pointer.

The problem is we alloc chip->bus in azx_codec_create
which will be called after we enable IRQ and enable unsolicited
event in azx_probe.

This will cause Oops due dereference NULL pointer. I meet it, good luck:)

[Rearranged the NULL check before the tracepoint and added another
 NULL check of bus->workq -- tiwai]

Signed-off-by: Wang YanQing <udknight@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/pci/hda/hda_codec.c