ext4: add validity checks for bitmap block numbers
authorTheodore Ts'o <tytso@mit.edu>
Tue, 27 Mar 2018 03:54:10 +0000 (23:54 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 31 May 2018 23:30:01 +0000 (00:30 +0100)
commitf278235ce148485cdb9dc990673943addafbd577
tree53e155b174872d3f0a28f9212f8c287b4a059226
parenteea55da54d3e425d6a5f3cfeb3f26adbb0330354
ext4: add validity checks for bitmap block numbers

commit 7dac4a1726a9c64a517d595c40e95e2d0d135f6f upstream.

An privileged attacker can cause a crash by mounting a crafted ext4
image which triggers a out-of-bounds read in the function
ext4_valid_block_bitmap() in fs/ext4/balloc.c.

This issue has been assigned CVE-2018-1093.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199181
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1560782
Reported-by: Wen Xu <wen.xu@gatech.edu>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
[bwh: Backported to 3.2:
 - In ext4_valid_block_bitmap(), goto err_out on error
 - In ext4_read_{block,inode}_bitmap(), return NULL on error
 - Adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext4/balloc.c
fs/ext4/ialloc.c