serial: msm-geni: Detect error from get_clk_div_rate
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Mon, 11 Aug 2025 17:03:39 +0000 (18:03 +0100)
committerCasey Connolly <casey.connolly@linaro.org>
Wed, 13 Aug 2025 13:17:36 +0000 (15:17 +0200)
commitf236451cb426fc3edaf756dac6346cd6273179b8
treeb49a4288af7a750ec28d332c2c576058c0218a6b
parent23e1a11f4e8e3333ddcbff3bf88763c711340fe2
serial: msm-geni: Detect error from get_clk_div_rate

In msm_serial_setbrg if the call to get_clk_div_rate fails then there
will not have been an assignment to clk_div which will lead to the call
to geni_serial_baud using an uninitialised value.
Check for an error from get_clk_div_rate and return an error code if so.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Casey Connolly <casey.connolly@linaro.org>
Link: https://lore.kernel.org/r/20250811-serial_msm_geni-v1-1-4499179491bc@linaro.org
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
drivers/serial/serial_msm_geni.c