USB: pl2303: fix data corruption on termios updates
authorJohan Hovold <jhovold@gmail.com>
Sun, 29 Dec 2013 18:22:53 +0000 (19:22 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 1 Apr 2014 23:58:40 +0000 (00:58 +0100)
commitf0c906da142a5bd2ed8e67230466c8483dd18dab
tree7eed9c0479b9c6c4c0b9dcafc5a484efed1c1924
parenta0809936e2ad052ef0fbdba0e258bfaf0c0dc9bc
USB: pl2303: fix data corruption on termios updates

commit 623c8263376c0b8a4b0c220232e7313d762cd0cc upstream.

Some PL2303 devices are known to lose bytes if you change serial
settings even to the same values as before. Avoid this by comparing the
encoded settings with the previsouly used ones before configuring the
device.

The common case was fixed by commit bf5e5834bffc6 ("pl2303: Fix mode
switching regression"), but this problem was still possible to trigger,
for instance, by using the TCSETS2-interface to repeatedly request
115201 baud, which gets mapped to 115200 and thus always triggers a
settings update.

Cc: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.2: adjust context; use dbg() instead of dev_dbg()]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/serial/pl2303.c