tracing: Do not add event files for modules that fail tracepoints
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Wed, 26 Feb 2014 18:37:38 +0000 (13:37 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 1 Apr 2014 23:58:57 +0000 (00:58 +0100)
commite9d0d0b01f89750d66f3e324607f6bb1f4db387a
tree3b2b2ff984c7125369d3add05677ed96316b343c
parent81b50572207dd2d5ebc9e1b8a203b29463b0369c
tracing: Do not add event files for modules that fail tracepoints

commit 45ab2813d40d88fc575e753c38478de242d03f88 upstream.

If a module fails to add its tracepoints due to module tainting, do not
create the module event infrastructure in the debugfs directory. As the events
will not work and worse yet, they will silently fail, making the user wonder
why the events they enable do not display anything.

Having a warning on module load and the events not visible to the users
will make the cause of the problem much clearer.

Link: http://lkml.kernel.org/r/20140227154923.265882695@goodmis.org
Fixes: 6d723736e472 "tracing/events: add support for modules to TRACE_EVENT"
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/linux/tracepoint.h
kernel/trace/trace_events.c
kernel/tracepoint.c