hpsa: fix a race in cmd_free/scsi_done
authorTomas Henzl <thenzl@redhat.com>
Thu, 1 Aug 2013 13:14:00 +0000 (15:14 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 14 Dec 2014 16:24:01 +0000 (16:24 +0000)
commite87cf8149d14c01a665e65029ad76530b228e901
treed52fc8c1cb60d9f7d2a7ac29a1fc9e28bf5bcb47
parent69cff65c8e35c2dc8763249e758ff55538809d27
hpsa: fix a race in cmd_free/scsi_done

commit 2cc5bfaf854463d9d1aa52091f60110fbf102a96 upstream.

When the driver calls scsi_done and after that frees it's internal
preallocated memory it can happen that a new job is enqueud before
the memory is freed. The allocation fails and the message
"cmd_alloc returned NULL" is shown.
Patch below fixes it by moving cmd->scsi_done after cmd_free.

Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Acked-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Masoud Sharbiani <msharbiani@twopensource.com>
drivers/scsi/hpsa.c