scsi: ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info
authorTyrel Datwyler <tyreld@linux.vnet.ibm.com>
Wed, 24 Jan 2018 02:11:32 +0000 (20:11 -0600)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 31 May 2018 23:30:11 +0000 (00:30 +0100)
commitda6941f4cc37699b2ff3894d279ca439548f768a
tree59b0d949f0a3c7ae9fbba8984434d429dcb96e7c
parentc86fd4aa55bf7729931aa4aeafb5383e049bedd1
scsi: ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info

commit c39813652700f3df552b6557530f1e5f782dbe2f upstream.

The fcp_rsp_info structure as defined in the FC spec has an initial 3
bytes reserved field. The ibmvfc driver mistakenly defined this field as
4 bytes resulting in the rsp_code field being defined in what should be
the start of the second reserved field and thus always being reported as
zero by the driver.

Ideally, we should wire ibmvfc up with libfc for the sake of code
deduplication, and ease of maintaining standardized structures in a
single place. However, for now simply fixup the definition in ibmvfc for
backporting to distros on older kernels. Wiring up with libfc will be
done in a followup patch.

Reported-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/scsi/ibmvscsi/ibmvfc.h