parisc: Ensure consistent state when switching to kernel stack at syscall entry
authorJohn David Anglin <dave.anglin@bell.net>
Sat, 29 Oct 2016 03:00:34 +0000 (23:00 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 23 Feb 2017 03:50:58 +0000 (03:50 +0000)
commitd22575559b82840a800554c6303012f74ca89041
treea60e5a75e6ffe718f087b632765597229341d669
parent192db9b925b664c39a04baa9f865f8ca64743f86
parisc: Ensure consistent state when switching to kernel stack at syscall entry

commit 6ed518328d0189e0fdf1bb7c73290d546143ea66 upstream.

We have one critical section in the syscall entry path in which we switch from
the userspace stack to kernel stack. In the event of an external interrupt, the
interrupt code distinguishes between those two states by analyzing the value of
sr7. If sr7 is zero, it uses the kernel stack. Therefore it's important, that
the value of sr7 is in sync with the currently enabled stack.

This patch now disables interrupts while executing the critical section.  This
prevents the interrupt handler to possibly see an inconsistent state which in
the worst case can lead to crashes.

Interestingly, in the syscall exit path interrupts were already disabled in the
critical section which switches back to the userspace stack.

Signed-off-by: John David Anglin <dave.anglin@bell.net>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/parisc/kernel/syscall.S