drm/i915: enable dip before writing data on gen4
authorPaulo Zanoni <paulo.r.zanoni@intel.com>
Thu, 3 May 2012 01:55:43 +0000 (22:55 -0300)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 May 2012 12:14:49 +0000 (13:14 +0100)
commitcab35eb95d74609cd26ad8a2084659ec4a65fe12
tree652ed0760848579d0b8ec82d5188449c69697c47
parente0791b5ffb456aa7de29391297e5dc93c1d123ff
drm/i915: enable dip before writing data on gen4

commit c1230df7e19e0f27655c0eb9d966c7e03be7cc50 upstream.

While testing with the intel_infoframes tool on gen4, I see that when
video DIP is disabled, what we write to the DATA memory is not exactly
what we read back later.

This regression has been introduce in

commit 64a8fc0145a1d0fdc25fc9367c2e6c621955fb3b
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Sep 22 11:16:00 2011 +0530

    drm/i915: fix ILK+ infoframe support

That commit was setting VIDEO_DIP_CTL to 0 when initializing, which
caused the problem.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43947
Tested-by: Yang Guang <guang.a.yang@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
[danvet: Pimped commit message by using the usual commit citation
layout.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/gpu/drm/i915/intel_hdmi.c