usb: renesas_usbhs: fix NULL pointer dereference in xfer_work()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Wed, 8 Jun 2016 07:32:49 +0000 (16:32 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 20 Nov 2016 01:01:23 +0000 (01:01 +0000)
commitc91172cb2b6997cf2830eccc3e4f2d948595fb64
tree2ca6460f7e7e6751686acee843c1d70f3fd1d2d4
parentdf47dba115bbac341b8d25bf851ad3d831fc0e03
usb: renesas_usbhs: fix NULL pointer dereference in xfer_work()

commit 4fdef698383db07d829da567e0e405fc41ff3a89 upstream.

This patch fixes an issue that the xfer_work() is possible to cause
NULL pointer dereference if the usb cable is disconnected while data
transfer is running.

In such case, a gadget driver may call usb_ep_disable()) before
xfer_work() is actually called. In this case, the usbhs_pkt_pop()
will call usbhsf_fifo_unselect(), and then usbhs_pipe_to_fifo()
in xfer_work() will return NULL.

Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/renesas_usbhs/fifo.c