TTY: drop driver reference in tty_open fail path
authorJiri Slaby <jslaby@suse.cz>
Wed, 12 Oct 2011 09:32:42 +0000 (11:32 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 18 Oct 2011 21:22:36 +0000 (14:22 -0700)
commitc290f8358acaeffd8e0c551ddcc24d1206143376
treef28068fd3da69c77b179d3955ec678c7ddeb7067
parent64d91cfaade2155ad048fe3b65238a052e29dde4
TTY: drop driver reference in tty_open fail path

When tty_driver_lookup_tty fails in tty_open, we forget to drop a
reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
tty lookup/reopen to caller).

Fix that by adding tty_driver_kref_put to the fail path.

I will refactor the code later. This is for the ease of backporting to
stable.

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: stable <stable@vger.kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/tty/tty_io.c