xen-blkback: only read request operation from shared ring once
authorRoger Pau Monné <roger.pau@citrix.com>
Tue, 3 Nov 2015 16:34:09 +0000 (16:34 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 22 Jan 2016 21:40:06 +0000 (21:40 +0000)
commitc25a100a2e2bf4ca34864f8123bf41e471addc49
treedaa4881b59c6a7668a9d58b276baacc7e22174e4
parentcbc4bd7f5ffddeff26a82f6e35baa6690f3e7474
xen-blkback: only read request operation from shared ring once

commit 1f13d75ccb806260079e0679d55d9253e370ec8a upstream.

A compiler may load a switch statement value multiple times, which could
be bad when the value is in memory shared with the frontend.

When converting a non-native request to a native one, ensure that
src->operation is only loaded once by using READ_ONCE().

This is part of XSA155.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
[bwh: Backported to 3.2:
 - s/READ_ONCE/ACCESS_ONCE/
 - Adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/block/xen-blkback/common.h