b43: stop format string leaking into error msgs
authorKees Cook <keescook@chromium.org>
Fri, 10 May 2013 21:48:21 +0000 (14:48 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 19 Jun 2013 01:16:59 +0000 (02:16 +0100)
commitbfb624e7fd41437a2c256adaf4041fe4414f8f26
tree2410efa506bff88257d74675a5fde45669863c2f
parent9fa72f6b1b0faa477a8317902e6f6eb2b32c832d
b43: stop format string leaking into error msgs

commit e0e29b683d6784ef59bbc914eac85a04b650e63c upstream.

The module parameter "fwpostfix" is userspace controllable, unfiltered,
and is used to define the firmware filename. b43_do_request_fw() populates
ctx->errors[] on error, containing the firmware filename. b43err()
parses its arguments as a format string. For systems with b43 hardware,
this could lead to a uid-0 to ring-0 escalation.

CVE-2013-2852

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/b43/main.c