dm table: fail dm_table_create on dm_round_up overflow
authorMikulas Patocka <mpatocka@redhat.com>
Sat, 23 Nov 2013 00:52:06 +0000 (19:52 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 3 Jan 2014 04:33:29 +0000 (04:33 +0000)
commita86ed8caf2fda2069ed910b42f80d7e7b7bc49d1
treeba9014a0cb375d89d59c8363e6261f0aca7ee975
parent8bd981aa4b609d3c97fceb4d81b212b68952b29c
dm table: fail dm_table_create on dm_round_up overflow

commit 5b2d06576c5410c10d95adfd5c4d8b24de861d87 upstream.

The dm_round_up function may overflow to zero.  In this case,
dm_table_create() must fail rather than go on to allocate an empty array
with alloc_targets().

This fixes a possible memory corruption that could be caused by passing
too large a number in "param->target_count".

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/md/dm-table.c