MIPS: OCTEON: make get_system_type() thread-safe
authorAaro Koskinen <aaro.koskinen@nsn.com>
Tue, 22 Jul 2014 11:51:08 +0000 (14:51 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 13 Sep 2014 22:41:46 +0000 (23:41 +0100)
commita17245332e650651e3d70aa94013d806d61a40cb
tree9f546830b4ffe36724fb4b8861c7ae004381fcc7
parente0d0f5bb569ae0d3d28cbce48259459b5615fcb4
MIPS: OCTEON: make get_system_type() thread-safe

commit 608308682addfdc7b8e2aee88f0e028331d88e4d upstream.

get_system_type() is not thread-safe on OCTEON. It uses static data,
also more dangerous issue is that it's calling cvmx_fuse_read_byte()
every time without any synchronization. Currently it's possible to get
processes stuck looping forever in kernel simply by launching multiple
readers of /proc/cpuinfo:

(while true; do cat /proc/cpuinfo > /dev/null; done) &
(while true; do cat /proc/cpuinfo > /dev/null; done) &
...

Fix by initializing the system type string only once during the early
boot.

Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Patchwork: http://patchwork.linux-mips.org/patch/7437/
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/mips/cavium-octeon/setup.c