tcp: Fix integer-overflows in TCP veno
authorChristoph Paasch <christoph.paasch@uclouvain.be>
Tue, 29 Jul 2014 10:07:27 +0000 (12:07 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 13 Sep 2014 22:41:48 +0000 (23:41 +0100)
commita16f7f29b9f02d0eda37675fb01d8d6aa54e892d
tree02aab22d35cb910c3b957525658200f588ca3a35
parentbf63acfdbf5c15e482a0b31043d666f3d3b1cf30
tcp: Fix integer-overflows in TCP veno

[ Upstream commit 45a07695bc64b3ab5d6d2215f9677e5b8c05a7d0 ]

In veno we do a multiplication of the cwnd and the rtt. This
may overflow and thus their result is stored in a u64. However, we first
need to cast the cwnd so that actually 64-bit arithmetic is done.

A first attempt at fixing 76f1017757aa0 ([TCP]: TCP Veno congestion
control) was made by 159131149c2 (tcp: Overflow bug in Vegas), but it
failed to add the required cast in tcp_veno_cong_avoid().

Fixes: 76f1017757aa0 ([TCP]: TCP Veno congestion control)
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/ipv4/tcp_veno.c