ALSA: echoaudio: Fix memory allocation
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 27 Jun 2016 19:06:51 +0000 (21:06 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 22 Aug 2016 21:37:17 +0000 (22:37 +0100)
commit92d6a07d168692736cca3fb0d8d22ad479d18669
tree183f45b0535cff46a39edba451c25d1599a52147
parent18d11b1d7785434cb791d49cd72f490e7b1dc5bc
ALSA: echoaudio: Fix memory allocation

commit 9c6795a9b3cbb56a9fbfaf43909c5c22999ba317 upstream.

'commpage_bak' is allocated with 'sizeof(struct echoaudio)' bytes.
We then copy 'sizeof(struct comm_page)' bytes in it.
On my system, smatch complains because one is 2960 and the other is 3072.

This would result in memory corruption or a oops.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/pci/echoaudio/echoaudio.c