md/raid10: fix bug when raid10 recovery fails to recover a block.
authorNeilBrown <neilb@suse.de>
Sun, 5 Jan 2014 23:35:34 +0000 (10:35 +1100)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 15 Feb 2014 19:20:17 +0000 (19:20 +0000)
commit8ea69324fe0ff7b7a7d0424b8518c63358971f68
tree8fd715ba4800bf13574b8c45fa742ca3d576e9f7
parent11bbcdfc5e8d7983403952f37543d085be5d6f58
md/raid10: fix bug when raid10 recovery fails to recover a block.

commit e8b849158508565e0cd6bc80061124afc5879160 upstream.

commit e875ecea266a543e643b19e44cf472f1412708f9
    md/raid10 record bad blocks as needed during recovery.

added code to the "cannot recover this block" path to record a bad
block rather than fail the whole recovery.
Unfortunately this new case was placed *after* r10bio was freed rather
than *before*, yet it still uses r10bio.
This is will crash with a null dereference.

So move the freeing of r10bio down where it is safe.

Fixes: e875ecea266a543e643b19e44cf472f1412708f9
Reported-by: Damian Nowak <spam@nowaker.net>
URL: https://bugzilla.kernel.org/show_bug.cgi?id=68181
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/md/raid10.c