vfs: read file_handle only once in handle_to_path
authorSasha Levin <sasha.levin@oracle.com>
Wed, 28 Jan 2015 20:30:43 +0000 (15:30 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 6 Aug 2015 23:32:14 +0000 (00:32 +0100)
commit8dfc8b9e8432f50606820b40a7d63618d9d61a07
tree7c29319b4edaa09860e5852a970902555e43aad5
parent4797489ce83a5f42d0b38089695a48d4a3d1ee0b
vfs: read file_handle only once in handle_to_path

commit 161f873b89136eb1e69477c847d5a5033239d9ba upstream.

We used to read file_handle twice.  Once to get the amount of extra
bytes, and once to fetch the entire structure.

This may be problematic since we do size verifications only after the
first read, so if the number of extra bytes changes in userspace between
the first and second calls, we'll have an incoherent view of
file_handle.

Instead, read the constant size once, and copy that over to the final
structure without having to re-read it again.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/fhandle.c