cdc_ncm: toggle altsetting to force reset before setup
authorBjørn Mork <bjorn@mork.no>
Thu, 3 Mar 2016 21:20:53 +0000 (22:20 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 30 Apr 2016 22:05:26 +0000 (00:05 +0200)
commit8b4375878ae845a8b5e672cdcf7e38dcfdef508e
tree7ed32eb1c5c17bf8125c3a81b43e37fa2a4e6320
parentceae7c032f44ba08de4a325100b77bc9abdc0fbd
cdc_ncm: toggle altsetting to force reset before setup

[ Upstream commit 48906f62c96cc2cd35753e59310cb70eb08cc6a5 ]

Some devices will silently fail setup unless they are reset first.
This is necessary even if the data interface is already in
altsetting 0, which it will be when the device is probed for the
first time.  Briefly toggling the altsetting forces a function
reset regardless of the initial state.

This fixes a setup problem observed on a number of Huawei devices,
appearing to operate in NTB-32 mode even if we explicitly set them
to NTB-16 mode.

Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.2: hard-code 1 for data_altsetting]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/usb/cdc_ncm.c