af_iucv: Move sockaddr length checks to before accessing sa_family in bind and connec...
authorMateusz Jurczyk <mjurczyk@google.com>
Fri, 23 Jun 2017 17:32:28 +0000 (19:32 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 12 Oct 2017 14:27:11 +0000 (15:27 +0100)
commit86c459a0e490e396d4fc920625519263dc37d4d7
treeac0658d9ea3de16626a06e3f22bcc1276d8cd68e
parent7dcc74d30e836ac96d2b9552c80e6fca03155c35
af_iucv: Move sockaddr length checks to before accessing sa_family in bind and connect handlers

commit e3c42b61ff813921ba58cfc0019e3fd63f651190 upstream.

Verify that the caller-provided sockaddr structure is large enough to
contain the sa_family field, before accessing it in bind() and connect()
handlers of the AF_IUCV socket. Since neither syscall enforces a minimum
size of the corresponding memory region, very short sockaddrs (zero or
one byte long) result in operating on uninitialized memory while
referencing .sa_family.

Fixes: 52a82e23b9f2 ("af_iucv: Validate socket address length in iucv_sock_bind()")
Signed-off-by: Mateusz Jurczyk <mjurczyk@google.com>
[jwi: removed unneeded null-check for addr]
Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/iucv/af_iucv.c