drm/radeon: fix a rare case of double kfree
authorIlija Hadzic <ihadzic@research.bell-labs.com>
Wed, 23 Jan 2013 18:59:05 +0000 (13:59 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 6 Feb 2013 04:33:47 +0000 (04:33 +0000)
commit8474b1ab89e4cbfaff2aa424ccf3f970ec0101e4
tree4845ff201797511a2241b8dedfa6b6f3e6d0ada9
parentf3825cc9679a5b7126c3d2bdf448b5453980d568
drm/radeon: fix a rare case of double kfree

commit 1da80cfa8727abf404fcee44d04743febea54069 upstream.

If one (but not both) allocations of p->chunks[].kpage[]
in radeon_cs_parser_init fail, the error path will free
the successfully allocated page, but leave a stale pointer
value in the kpage[] field. This will later cause a
double-free when radeon_cs_parser_fini is called.
This patch fixes the issue by forcing both pointers to NULL
after kfree in the error path.

The circumstances under which the problem happens are very
rare. The card must be AGP and the system must run out of
kmalloc area just at the right time so that one allocation
succeeds, while the other fails.

Signed-off-by: Ilija Hadzic <ihadzic@research.bell-labs.com>
Cc: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
[bwh: Backported to 3.2: s/p->chunk_ib_idx/i/]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/gpu/drm/radeon/radeon_cs.c