mwifiex: debugfs: Fix (sometimes) off-by-1 SSID print
authorBrian Norris <briannorris@chromium.org>
Mon, 9 Jan 2017 23:33:50 +0000 (15:33 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 5 Jun 2017 20:13:44 +0000 (21:13 +0100)
commit80ffaf9e0e91fb429ee1d14f69f05bbe29b4d137
tree5520557636b10e2f14eb235e146f46c6e6f8c06c
parent20ed72dba2080e90c619b26a358ab202ba799c00
mwifiex: debugfs: Fix (sometimes) off-by-1 SSID print

commit 6183468a23fc6b6903f8597982017ad2c7fdefcf upstream.

Similar to commit fcd2042e8d36 ("mwifiex: printk() overflow with 32-byte
SSIDs"), we failed to account for the existence of 32-char SSIDs in our
debugfs code. Unlike in that case though, we zeroed out the containing
struct first, and I'm pretty sure we're guaranteed to have some padding
after the 'ssid.ssid' and 'ssid.ssid_len' fields (the struct is 33 bytes
long).

So, this is the difference between:

  # cat /sys/kernel/debug/mwifiex/mlan0/info
  ...
  essid="0123456789abcdef0123456789abcdef "
  ...

and the correct output:

  # cat /sys/kernel/debug/mwifiex/mlan0/info
  ...
  essid="0123456789abcdef0123456789abcdef"
  ...

Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
[bwh: Backported to 3.2: adjust filename]g
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/mwifiex/debugfs.c