packet: handle too big packets for PACKET_V3
authorEric Dumazet <edumazet@google.com>
Fri, 15 Aug 2014 16:16:04 +0000 (09:16 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 5 Jun 2017 20:13:53 +0000 (21:13 +0100)
commit7a57c26823a02d024316600b7b814a047d46c373
tree46402da7de6535263ae9a6fa9120ce06ee85fd3e
parentc2e7959f2ea446a417bf2cdb79792575852d17bb
packet: handle too big packets for PACKET_V3

commit dc808110bb62b64a448696ecac3938902c92e1ab upstream.

af_packet can currently overwrite kernel memory by out of bound
accesses, because it assumed a [new] block can always hold one frame.

This is not generally the case, even if most existing tools do it right.

This patch clamps too long frames as API permits, and issue a one time
error on syslog.

[  394.357639] tpacket_rcv: packet too big, clamped from 5042 to 3966. macoff=82

In this example, packet header tp_snaplen was set to 3966,
and tp_len was set to 5042 (skb->len)

Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: f6fb8f100b80 ("af-packet: TPACKET_V3 flexible buffer implementation.")
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/packet/af_packet.c