ALSA: usb-audio: Add sanity checks to FE parser
authorTakashi Iwai <tiwai@suse.de>
Tue, 21 Nov 2017 15:55:51 +0000 (16:55 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 13 Feb 2018 18:32:19 +0000 (18:32 +0000)
commit76747915c13bd6b8a070516ec8ddc361cf2228bc
tree2d760ff67554c737d8a06d0eecfaa5054a3b3240
parentfe37537fcbfdd8caee979ad3114c5bbbb024605c
ALSA: usb-audio: Add sanity checks to FE parser

commit d937cd6790a2bef2d07b500487646bd794c039bb upstream.

When the usb-audio descriptor contains the malformed feature unit
description with a too short length, the driver may access
out-of-bounds.  Add a sanity check of the header size at the beginning
of parse_audio_feature_unit().

Fixes: 23caaf19b11e ("ALSA: usb-mixer: Add support for Audio Class v2.0")
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
[bwh: Backported to 3.2: use snd_printk() for logging]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/usb/mixer.c