staging: comedi: dt282x: dt282x_ai_insn_read() always fails
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 20 Aug 2013 08:57:35 +0000 (11:57 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Oct 2013 20:05:59 +0000 (21:05 +0100)
commit63a77d815edb770711efc6dc1b2777f49d83d287
treee78588ef4be5c6e115c6fa4c68daa9db706f9a35
parentb18b089695313ab6b6a4f7569aa3a6c02ddcc3c6
staging: comedi: dt282x: dt282x_ai_insn_read() always fails

commit 2c4283ca7cdcc6605859c836fc536fcd83a4525f upstream.

In dt282x_ai_insn_read() we call this macro like:
wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;);
Because the if statement doesn't have curly braces it means we always
return -ETIME and the function never succeeds.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/staging/comedi/drivers/dt282x.c