HID: core: Avoid uninitialized buffer access
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 18 Sep 2015 23:31:33 +0000 (16:31 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 27 Nov 2015 12:48:19 +0000 (12:48 +0000)
commit604bfd00358e3d7fce8dc789fe52d2f2be0fa4c7
treec3f6c09b4a1be86c139463e652cbf09860e01075
parentadc82592cde76e5d6182c66bf0c67560f0ee0abf
HID: core: Avoid uninitialized buffer access

commit 79b568b9d0c7c5d81932f4486d50b38efdd6da6d upstream.

hid_connect adds various strings to the buffer but they're all
conditional. You can find circumstances where nothing would be written
to it but the kernel will still print the supposedly empty buffer with
printk. This leads to corruption on the console/in the logs.

Ensure buf is initialized to an empty string.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
[dvhart: Initialize string to "" rather than assign buf[0] = NULL;]
Cc: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/hid/hid-core.c