ALSA: core: Fix unexpected error at replacing user TLV
authorTakashi Iwai <tiwai@suse.de>
Tue, 22 Aug 2017 06:15:13 +0000 (08:15 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 11 Nov 2017 13:34:30 +0000 (13:34 +0000)
commit5bb5cc4ec4fa756070edf5e851fa9607dbf6d3a8
tree4ce0f6db51d1ad00f49e417b8ebd67241939e94d
parentb24bc551bf907ff6a5200b990a95b43a1938123b
ALSA: core: Fix unexpected error at replacing user TLV

commit 88c54cdf61f508ebcf8da2d819f5dfc03e954d1d upstream.

When user tries to replace the user-defined control TLV, the kernel
checks the change of its content via memcmp().  The problem is that
the kernel passes the return value from memcmp() as is.  memcmp()
gives a non-zero negative value depending on the comparison result,
and this shall be recognized as an error code.

The patch covers that corner-case, return 1 properly for the changed
TLV.

Fixes: 8aa9b586e420 ("[ALSA] Control API - more robust TLV implementation")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/core/control.c