virtio: console: fix race in port_fops_open() and port unplug
authorAmit Shah <amit.shah@redhat.com>
Mon, 29 Jul 2013 04:47:13 +0000 (14:17 +0930)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 10 Sep 2013 00:57:16 +0000 (01:57 +0100)
commit55fa4acf3f2750cf70fbae4534b630f74397e6b9
treee3821c109b6082dbbbff16bcd5603fcec66ce9c6
parent0426ea8291c0cdcf0d585c39a7bfae18e621d93b
virtio: console: fix race in port_fops_open() and port unplug

commit 671bdea2b9f210566610603ecbb6584c8a201c8c upstream.

Between open() being called and processed, the port can be unplugged.
Check if this happened, and bail out.

A simple test script to reproduce this is:

while true; do for i in $(seq 1 100); do echo $i > /dev/vport0p3; done; done;

This opens and closes the port a lot of times; unplugging the port while
this is happening triggers the bug.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/char/virtio_console.c