ext2: Fix fs corruption in ext2_get_xip_mem()
authorJan Kara <jack@suse.cz>
Tue, 5 Nov 2013 00:15:38 +0000 (01:15 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 5 Nov 2014 20:27:49 +0000 (20:27 +0000)
commit4b808fd2ef61f6d8bdaabe30b67da3f5ea9948bf
tree1dfcfe628140396173d7fe1cd4c01f19108a6d66
parent15004af9098f718266649c90be5a684bdd680b5a
ext2: Fix fs corruption in ext2_get_xip_mem()

commit 7ba3ec5749ddb61f79f7be17b5fd7720eebc52de upstream.

Commit 8e3dffc651cb "Ext2: mark inode dirty after the function
dquot_free_block_nodirty is called" unveiled a bug in __ext2_get_block()
called from ext2_get_xip_mem(). That function called ext2_get_block()
mistakenly asking it to map 0 blocks while 1 was intended. Before the
above mentioned commit things worked out fine by luck but after that commit
we started returning that we allocated 0 blocks while we in fact
allocated 1 block and thus allocation was looping until all blocks in
the filesystem were exhausted.

Fix the problem by properly asking for one block and also add assertion
in ext2_get_blocks() to catch similar problems.

Reported-and-tested-by: Andiry Xu <andiry.xu@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/ext2/inode.c
fs/ext2/xip.c