rtc: pcap: Initialize drvdata before registering device
authorJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:30:57 +0000 (17:30 -0700)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 01:02:04 +0000 (18:02 -0700)
commit4b3687f9c18156cdb71729fe4e0c3000f7e4d7de
treed874e58a7cf4bc488707f956d0160b2eaab57b86
parent93015236d92bf9ea746c0b10c3c1d9058cb11f82
rtc: pcap: Initialize drvdata before registering device

Commit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the device or platform drvdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the drvdata is initialized prior to registering
the rtc device.

CC: Wolfram Sang <w.sang@pengutronix.de>
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-pcap.c