net: phy: vitesse: Fix incorrect test for timeout
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Wed, 6 Aug 2025 09:37:26 +0000 (10:37 +0100)
committerJerome Forissier <jerome.forissier@linaro.org>
Mon, 18 Aug 2025 12:08:57 +0000 (14:08 +0200)
commit4b2d64f3885a83fd001993785f74f70cc6045acc
treeb5260a7e3064ae4e4a38c25f3e0e717a6e37dfd3
parent0ce7fef9e2154d188bd50ae687fb666faac8fe7b
net: phy: vitesse: Fix incorrect test for timeout

In vsc8514_config there is a while loop for detecting a config failure
using a timeout counter with a post-decrement. In the case of a timeout
this will result in the loop exiting with timeout == -1 so use that as
the test below the loop to detect that the timeout occurred.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
drivers/net/phy/vitesse.c