HID: picolcd_core: validate output report details
authorKees Cook <keescook@chromium.org>
Wed, 28 Aug 2013 20:31:52 +0000 (22:31 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Oct 2013 20:06:02 +0000 (21:06 +0100)
commit49ad1670d8a0a8e9a7f84272e3054c80563b87bc
tree922a25bbca19ff9d0cfa327f54c456a7ba1255a9
parentc790976bda06884d78a1f8208d74e566ac41954e
HID: picolcd_core: validate output report details

commit 1e87a2456b0227ca4ab881e19a11bb99d164e792 upstream.

A HID device could send a malicious output report that would cause the
picolcd HID driver to trigger a NULL dereference during attr file writing.

[jkosina@suse.cz: changed

report->maxfield < 1

to

report->maxfield != 1

as suggested by Bruno].

CVE-2013-2899

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/hid/hid-picolcd.c