iscsi-target: chap auth shouldn't match username with trailing garbage
authorEric Seppanen <eric@purestorage.com>
Wed, 20 Nov 2013 22:19:52 +0000 (14:19 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 3 Jan 2014 04:33:24 +0000 (04:33 +0000)
commit47e67db4779d6fdb0d3a71283265a272d99af2b3
tree68b616e8e2b9e10059a046293508540898cd348b
parent6d8fcca06072afed5d917c980ac233abd4f03e0b
iscsi-target: chap auth shouldn't match username with trailing garbage

commit 86784c6bdeeef78eed94d298be7a8879f6a97ee2 upstream.

In iSCSI negotiations with initiator CHAP enabled, usernames with
trailing garbage are permitted, because the string comparison only
checks the strlen of the configured username.

e.g. "usernameXXXXX" will be permitted to match "username".

Just check one more byte so the trailing null char is also matched.

Signed-off-by: Eric Seppanen <eric@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/target/iscsi/iscsi_target_auth.c