led: Fix next Coverity scan error
authorHeiko Schocher <hs@denx.de>
Wed, 26 Feb 2025 09:18:58 +0000 (10:18 +0100)
committerTom Rini <trini@konsulko.com>
Tue, 4 Mar 2025 18:07:23 +0000 (12:07 -0600)
commit409d37e869e91453d94319792e17d1d882259b49
treedb272d11811b098bdb01495ffaa2b3ab633022a6
parentb6f8da1c2e1a91fbf3059bbd68e3355d76c88b42
led: Fix next Coverity scan error

The following was reported by Coverity scan:

*** CID 542488:  Control flow issues  (NO_EFFECT)
/drivers/led/led-uclass.c: 277 in led_get_function_name()
271                     return uc_plat->label;
272
273             /* Now try to detect function label name */
274             func = dev_read_string(dev, "function");
275             cp = dev_read_u32(dev, "color", &color);
276             // prevent coverity scan error CID 541279: (TAINTED_SCALAR)
>>>     CID 542488:  Control flow issues  (NO_EFFECT)
>>>     This less-than-zero comparison of an unsigned value is never true. "color < 0U".
277             if (color < LED_COLOR_ID_WHITE || color >= LED_COLOR_ID_MAX)
278                     cp = -EINVAL;
279

Fix it.

Addresses-Coverity-ID: 542488
Link: https://lists.denx.de/pipermail/u-boot/2025-February/581567.html
Signed-off-by: Heiko Schocher <hs@denx.de>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
drivers/led/led-uclass.c