crypto: gcm - Fix rfc4543 decryption crash
authorHerbert Xu <herbert@gondor.apana.org.au>
Fri, 18 Mar 2016 14:42:40 +0000 (22:42 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 15 Jun 2016 20:28:10 +0000 (21:28 +0100)
commit3cfb9a410bd0489f73c69db040f727ff05df29e1
tree266c750b61895330876b15418ce83a16ff4e7f05
parentc9dc564e3240cbfa4ec46ff02f33fa5a1b93e468
crypto: gcm - Fix rfc4543 decryption crash

This bug has already bee fixed upstream since 4.2.  However, it
was fixed during the AEAD conversion so no fix was backported to
the older kernels.

When we do an RFC 4543 decryption, we will end up writing the
ICV beyond the end of the dst buffer.  This should lead to a
crash but for some reason it was never noticed.

This patch fixes it by only writing back the ICV for encryption.

Fixes: d733ac90f9fe ("crypto: gcm - fix rfc4543 to handle async...")
Reported-by: Patrick Meyer <patrick.meyer@vasgard.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
crypto/gcm.c