Bluetooth: Fix SSP acceptor just-works confirmation without MITM
authorJohan Hedberg <johan.hedberg@intel.com>
Mon, 9 Jun 2014 10:58:14 +0000 (13:58 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 Jul 2014 12:33:52 +0000 (13:33 +0100)
commit373d1dfcffc63c68184419264a7eaed422c7958e
tree4d3b3b6a549343d3b6f91b59e9befa30b21d70a9
parentd6b05102d11032e0809dabc7231cbcdb6eba4cdc
Bluetooth: Fix SSP acceptor just-works confirmation without MITM

commit ba15a58b179ed76a7e887177f2b06de12c58ec8f upstream.

From the Bluetooth Core Specification 4.1 page 1958:

"if both devices have set the Authentication_Requirements parameter to
one of the MITM Protection Not Required options, authentication stage 1
shall function as if both devices set their IO capabilities to
DisplayOnly (e.g., Numeric comparison with automatic confirmation on
both devices)"

So far our implementation has done user confirmation for all just-works
cases regardless of the MITM requirements, however following the
specification to the word means that we should not be doing confirmation
when neither side has the MITM flag set.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Tested-by: Szymon Janc <szymon.janc@tieto.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
[bwh: Backported to 3.2: s/conn->flags/conn->pend/]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/bluetooth/hci_event.c