rtc: max8925: Initialize drvdata before registering device
authorJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:26:25 +0000 (17:26 -0700)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 01:02:00 +0000 (18:02 -0700)
commit2f5c4fe8f9811152d69ef5cd020e095a1f84ca65
tree8a761a6772cbeae7d9661b29e55a7a9965719178
parenta015dbc110a97ed3147546a9c914f18f71d798d0
rtc: max8925: Initialize drvdata before registering device

Commit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the device or platform drvdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the drvdata is initialized prior to registering
the rtc device.

CC: Wolfram Sang <w.sang@pengutronix.de>
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-max8925.c